Attention is currently required from: fixeria, pespin.

View Change

3 comments:

• Commit Message:

  • Patch Set #5, Line 9: 3 entries are enough for random access on CCCH

    Is it strictly necessary to remember up to exactly 3 requests? […]

    No, we must compare only the last 3 channel requests for an IMM.ASS or reject, as defined in the specs. On uplink request we need to remember up to 5 uplink requests.

    I added a comment with reference to the specs in the fixup.

• File src/host/layer23/src/mobile/gsm48_rr.c:

  • Patch Set #5, Line 2367: static int gsm48_match_ra(struct osmocom_ms *ms, struct gsm48_req_ref *ref, int hist_num)

    unsigned. […]

    Done

  • Patch Set #5, Line 2495: if (gsm48_match_ra(ms, &ia->req_ref, 3)) {

    sounds like we want to have defined for magic numbers 3 and 5 ;)

    Done

To view, visit change 34485. To unsubscribe, or for help writing mail filters, visit settings.