[S] Change in pysim[master]: Print SMSC in pySim-read.py - gerrit-log

19 Jan 2026


      Attention is currently required from: phcoder.
fixeria has posted comments on this change by phcoder. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email )
Change subject: Print SMSC in pySim-read.py
......................................................................
Patch Set 14:
(1 comment)
File pySim-read.py:
https://gerrit.osmocom.org/c/pysim/+/41786/comment/ddc12aea_0d8520b7?usp=ema... :
PS14, Line 148: smsc_a.get('ton_npi', None).get
`smsc_a.get()` may return `None`, resulting in an exception:
```
AttributeError: 'NoneType' object has no attribute 'get'
```
Same applies to `smsc_n.get()` above: `smsc_n` can be `None`,
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f
Gerrit-Change-Number: 41786
Gerrit-PatchSet: 14
Gerrit-Owner: phcoder phcoder@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: phcoder phcoder@gmail.com
Gerrit-Comment-Date: Mon, 19 Jan 2026 12:55:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No