Attention is currently required from: phcoder.
View Change
1 comment:
File pySim-read.py:
Patch Set #14, Line 148: smsc_a.get('ton_npi', None).get
`smsc_a.get()` may return `None`, resulting in an exception:
```
AttributeError: 'NoneType' object has no attribute 'get'
```
Same applies to `smsc_n.get()` above: `smsc_n` can be `None`,
To view, visit change 41786. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f
Gerrit-Change-Number: 41786
Gerrit-PatchSet: 14
Gerrit-Owner: phcoder <phcoder@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: phcoder <phcoder@gmail.com>
Gerrit-Comment-Date: Mon, 19 Jan 2026 12:55:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No