Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 4: (4 comments) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/5c6f7276_7447096c PS4, Line 515: int osmo_ss7_asp_get_trans_proto(const struct osmo_ss7_asp *asp); Is this needed by any app right now? Otherwise I vote for keeping it private until needed. https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/26384a30_1ce00802 PS4, Line 566: int trans_proto; You need to update TODO-RELEASE about new fields and APIs. I think right now all these structs are allocated by libosmo-sccp itself, so it's fine using same app with newer version. The opposite would be wrong though, so you need to say ABI BREAK here. File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/007917a1_cece3754 PS3, Line 616: osmo_sccp_simple_client2(void *ctx, const char *name, uint32_t default_pc, My understanding is that for current ticket only osmo-stp is needed. It is ofc desirable to support them in other users of libosmo-sccp, but usually those use the _simple_* APIs, which we want to drop at some point. So at least submit that part as a different patch and we can discuss whether we merge it or whether we rather move osmo-bsc/osmo-msc to get rid of the _simple_ APIs. File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/ccf7e884_d20e5592 PS4, Line 133: #define PROTO_MUX(proto, trans_proto) \ I still think this should be changed to avoid doing assumptions about size and max value of trans_proto. But I'm not gona block if nobody else cares. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Feb 2024 13:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment