Attention is currently required from: fixeria, jolly, laforge.

View Change

4 comments:

• File include/osmocom/sigtran/osmo_ss7.h:

  • Patch Set #4, Line 515: int osmo_ss7_asp_get_trans_proto(const struct osmo_ss7_asp *asp);

    Is this needed by any app right now? Otherwise I vote for keeping it private until needed.

  • Patch Set #4, Line 566: int trans_proto;

    You need to update TODO-RELEASE about new fields and APIs.
    I think right now all these structs are allocated by libosmo-sccp itself, so it's fine using same app with newer version. The opposite would be wrong though, so you need to say ABI BREAK here.

• File include/osmocom/sigtran/osmo_ss7.h:

  • Patch Set #3, Line 616: osmo_sccp_simple_client2(void *ctx, const char *name, uint32_t default_pc,

    > Any input is welcome. I'll continue investigating this. […]

    My understanding is that for current ticket only osmo-stp is needed.
    It is ofc desirable to support them in other users of libosmo-sccp, but usually those use the _simple_* APIs, which we want to drop at some point. So at least submit that part as a different patch and we can discuss whether we merge it or whether we rather move osmo-bsc/osmo-msc to get rid of the _simple_ APIs.

• File src/osmo_ss7_asp.c:

  • Patch Set #4, Line 133: #define PROTO_MUX(proto, trans_proto) \

    I still think this should be changed to avoid doing assumptions about size and max value of trans_proto. But I'm not gona block if nobody else cares.

To view, visit change 35796. To unsubscribe, or for help writing mail filters, visit settings.