Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28328 ) Change subject: lchan_select: implement dynamic selection mode for assignment ...................................................................... Patch Set 2: (2 comments) File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/592c48e1_f025f9ca PS2, Line 229: /* Sort by TRX power is descending order (if needed) */ "in descending"? https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/d947b786_f89e82cc PS2, Line 231: qsort(&trx_list[0], bts->num_trx, sizeof(trx), &qsort_func); I'm also not liking the fact that you seem to be basically mixing logic for different alloc algorithms in different steps. I'd really go for having a func ptr or switch statement with different per-algo functions doing each whatever. Otherwise the whole thing looks too complex imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b7a0d706976b73cc5c30a8714b830811addfe8d Gerrit-Change-Number: 28328 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jun 2022 09:53:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment