Attention is currently required from: fixeria.

View Change

2 comments:

• File src/osmo-bsc/lchan_select.c:

  • Patch Set #2, Line 229: /* Sort by TRX power is descending order (if needed) */

    "in descending"?

  • Patch Set #2, Line 231: qsort(&trx_list[0], bts->num_trx, sizeof(trx), &qsort_func);

    I'm also not liking the fact that you seem to be basically mixing logic for different alloc algorithms in different steps.
    I'd really go for having a func ptr or switch statement with different per-algo functions doing each whatever. Otherwise the whole thing looks too complex imho.

To view, visit change 28328. To unsubscribe, or for help writing mail filters, visit settings.