Attention is currently required from: canghaiwuhen.

Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email )

Change subject: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets. If the PDP is not released after successful attachment, the module will restart, and subsequent TCP connections will fail. ......................................................................

Patch Set 4:

(6 comments)

File src/sgsn/gprs_gmm.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/c55ee09f_d7da6f88?usp... : PS4, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, it means it has restarted and lost its PDP state. trailing whitespace

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/4154947e_40a46358?usp... : PS4, Line 1341: * We must clean up the old PDP context on the SGSN side; otherwise, the SGSN will not recreate them, leading to communication failure. */ code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/7d7e51b4_649bd5f0?usp... : PS4, Line 1341: * We must clean up the old PDP context on the SGSN side; otherwise, the SGSN will not recreate them, leading to communication failure. */ please, no space before tabs

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/ee3726d4_736165b3?usp... : PS4, Line 1368: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) { suspect code indent for conditional statements (24, 24)

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/1cb547cf_b4b79eb3?usp... : PS4, Line 1372: } code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/1e516135_bbd620dc?usp... : PS4, Line 1372: } please, no spaces at the start of a line