Attention is currently required from: canghaiwuhen.

View Change

6 comments:

• File src/sgsn/gprs_gmm.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, it means it has restarted and lost its PDP state.

    trailing whitespace

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 1341: * We must clean up the old PDP context on the SGSN side; otherwise, the SGSN will not recreate them, leading to communication failure. */

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 1341: * We must clean up the old PDP context on the SGSN side; otherwise, the SGSN will not recreate them, leading to communication failure. */

    please, no space before tabs

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 1368: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) {

    suspect code indent for conditional statements (24, 24)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 1372: }

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 1372: }

    please, no spaces at the start of a line

To view, visit change 42050. To unsubscribe, or for help writing mail filters, visit settings.