Attention is currently required from: falconia, fixeria, pespin.

Thorkell Thorkelsson has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email )

Change subject: tch: fix RTP clock not ticking for unhandled payload types ......................................................................

Patch Set 2:

(1 comment)

File src/osmo-bts-sysmo/tch.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42244/comment/f9cfe304_73e1abba?usp=... : PS2, Line 601: FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented

I believe this comment is still valid: `GsmL1_TchPlType_Amr_SidBad` is not handled in the switch sta […]

The patch catches Amr_SidBad in the generic fallback case. As SidBad indicates a corrupted SID with no valid AMR data, generating an empty RTP tick would be the appropriate response. Adding a specific case for it would result in the same response.