Attention is currently required from: falconia, fixeria, pespin. Thorkell Thorkelsson has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-sysmo/tch.c: https://gerrit.osmocom.org/c/osmo-bts/+/42244/comment/f9cfe304_73e1abba?usp=... : PS2, Line 601: FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented
I believe this comment is still valid: `GsmL1_TchPlType_Amr_SidBad` is not handled in the switch sta […] The patch catches Amr_SidBad in the generic fallback case. As SidBad indicates a corrupted SID with no valid AMR data, generating an empty RTP tick would be the appropriate response. Adding a specific case for it would result in the same response.
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 2 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon@freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: falconia <falcon@freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sun, 01 Mar 2026 16:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>