Attention is currently required from: pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30743 )

Change subject: {trxcon,virt_phy}: shared GPRS L1 (MAC) implementation ......................................................................

Patch Set 10:

(6 comments)

File src/host/trxcon/include/osmocom/bb/l1gprs/l1gprs.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/a0d6be5c_12e7c52a PS6, Line 11: struct l1gprs_ul_tbf {

you are not storing tbf_nr here?

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/c182e374_2bbf8b48 PS6, Line 16: struct l1gprs_dl_tbf {

same here. […]

Done

File src/host/trxcon/src/gprs.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/76728113_22e03602 PS6, Line 116: .slotmask = req->slotmask,

.tbf_nr = ,

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/ed6f55fe_d0e2465a PS6, Line 125: pdch->ul_tbf_mask |= (1 << req->tbf_nr);

you are assuming really small values of tbf_nr here, which doesn't necessarily need to be the case. […]

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/3c8e86dc_49d35ffe PS6, Line 167: tbf = &gprs->dl_tbf[req->tbf_nr];

this needs to be a llist (due to potentially high tbf_nr ids).

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/871dd056_3dbc2b5c PS6, Line 262: for (unsigned int i = 0; i < ARRAY_SIZE(gprs->dl_tbf); i++) {

If you regenerate the bitmask I talked about above each time a TBF is configured, then in here you c […]

Done