Attention is currently required from: pespin.

View Change

6 comments:

• File src/host/trxcon/include/osmocom/bb/l1gprs/l1gprs.h:

  • Patch Set #6, Line 11: struct l1gprs_ul_tbf {

    you are not storing tbf_nr here?

    Done

  • Patch Set #6, Line 16: struct l1gprs_dl_tbf {

    same here. […]

    Done

• File src/host/trxcon/src/gprs.c:

  • Patch Set #6, Line 116: .slotmask = req->slotmask,

    .tbf_nr = ,

    Done

  • Patch Set #6, Line 125: pdch->ul_tbf_mask |= (1 << req->tbf_nr);

    you are assuming really small values of tbf_nr here, which doesn't necessarily need to be the case. […]

    Done

  • Patch Set #6, Line 167: tbf = &gprs->dl_tbf[req->tbf_nr];

    this needs to be a llist (due to potentially high tbf_nr ids).

    Done

  • Patch Set #6, Line 262: for (unsigned int i = 0; i < ARRAY_SIZE(gprs->dl_tbf); i++) {

    If you regenerate the bitmask I talked about above each time a TBF is configured, then in here you c […]

    Done

To view, visit change 30743. To unsubscribe, or for help writing mail filters, visit settings.