Attention is currently required from: dexter, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141?usp=email )
Change subject: improve HNBAP error logging ......................................................................
Patch Set 2:
(2 comments)
File src/osmo-hnbgw/hnbgw.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141/comment/073fa8cb_2e62dd03 PS2, Line 192: LOGHNB(hnb, DHNBAP, LOGL_ERROR, "Failed to allocate new ue_context\n");
I think so too. When memory allocation fails something is really wrong. […]
hah i blindly added logging to all 'return' and didn't even notice.
(a more immediate argument: when malloc fails, how should logging work.)
File src/osmo-hnbgw/hnbgw_hnbap.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141/comment/719e24b1_04b481ac PS2, Line 152: "Failed to encode HNBAP UE Register Accept message for UE IMSI-%s TMSI-0x%x\n",
0x%08x (in all log lines below too).
Done
-
neels