Attention is currently required from: dexter, pespin.

View Change

2 comments:

• File src/osmo-hnbgw/hnbgw.c:

  • Patch Set #2, Line 192: LOGHNB(hnb, DHNBAP, LOGL_ERROR, "Failed to allocate new ue_context\n");

    I think so too. When memory allocation fails something is really wrong. […]

    hah i blindly added logging to all 'return' and didn't even notice.

    (a more immediate argument: when malloc fails, how should logging work.)

• File src/osmo-hnbgw/hnbgw_hnbap.c:

  • Patch Set #2, Line 152: "Failed to encode HNBAP UE Register Accept message for UE IMSI-%s TMSI-0x%x\n",

    0x%08x (in all log lines below too).

    Done

To view, visit change 36141. To unsubscribe, or for help writing mail filters, visit settings.