Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27631 )

Change subject: libosmo-pfcp: implement PFCP header and msg handling ......................................................................

Patch Set 3:

(2 comments)

File include/osmocom/pfcp/pfcp_msg.h:

https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/2eb94b6e_92431699 PS3, Line 44: #define OSMO_LOG_PFCP_MSG_SRC(M, LEVEL, file, line, FMT, ARGS...) do { \

This starts to look as too much for a macro imho, it may make sense to move it to a variadic functio […]

Agree, let's avoid over bloated macros please.

File src/libosmo-pfcp/pfcp_msg.c:

https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/42a51b0f_00325476 PS3, Line 65: struct osmo_pfcp_header_common { Don't you need to add conditional blocks for little/big endian here?