Attention is currently required from: neels, pespin.

View Change

2 comments:

• File include/osmocom/pfcp/pfcp_msg.h:

  • Patch Set #3, Line 44: #define OSMO_LOG_PFCP_MSG_SRC(M, LEVEL, file, line, FMT, ARGS...) do { \

    This starts to look as too much for a macro imho, it may make sense to move it to a variadic functio […]

    Agree, let's avoid over bloated macros please.

• File src/libosmo-pfcp/pfcp_msg.c:

  • Patch Set #3, Line 65: struct osmo_pfcp_header_common {

    Don't you need to add conditional blocks for little/big endian here?

To view, visit change 27631. To unsubscribe, or for help writing mail filters, visit settings.