Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708 ) Change subject: Proper exit if bsc_nat_fsm fails to start ...................................................................... Patch Set 2: (2 comments) File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708/comment/1ee9a472_81a0b47b PS2, Line 479: osmo_fsm_inst_dispatch(bsc_nat->fi, BSC_NAT_FSM_EV_START, NULL); int bsc_nat_fsm_start(struct bsc_nat *bsc_nat) { int rc; rc = osmo_fsm_inst_dispatch(bsc_nat->fi, BSC_NAT_FSM_EV_START, NULL); if (rc) return rc; return bsc_nat->fi->state == BSC_NAT_FSM_ST_STARTED; } File src/osmo-bsc-nat/main.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708/comment/90416ec2_fc23c400 PS2, Line 202: if (!bsc_nat_fsm_is_started(g_bsc_nat)) { This looks weird. Why not: if (bsc_nat_fsm_start(g_bsc_nat) < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ia8bbe6ae908d5c3ce49f71b43c950497aeebb6d6 Gerrit-Change-Number: 27708 Gerrit-PatchSet: 2 Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 08 Apr 2022 16:51:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment