Attention is currently required from: osmith.

View Change

2 comments:

• File src/osmo-bsc-nat/bsc_nat_fsm.c:

  • Patch Set #2, Line 479: osmo_fsm_inst_dispatch(bsc_nat->fi, BSC_NAT_FSM_EV_START, NULL);

    int bsc_nat_fsm_start(struct bsc_nat *bsc_nat) {
    int rc;
    rc = osmo_fsm_inst_dispatch(bsc_nat->fi, BSC_NAT_FSM_EV_START, NULL);
    if (rc)
        return rc;
    return bsc_nat->fi->state == BSC_NAT_FSM_ST_STARTED;
    }

• File src/osmo-bsc-nat/main.c:

  • Patch Set #2, Line 202: if (!bsc_nat_fsm_is_started(g_bsc_nat)) {

    This looks weird. Why not:
    if (bsc_nat_fsm_start(g_bsc_nat) < 0)
       exit(1);

To view, visit change 27708. To unsubscribe, or for help writing mail filters, visit settings.