Attention is currently required from: fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30616 )

Change subject: ipa: Add ipa_client_conn_open2 with connect timeout argument ......................................................................

Patch Set 2: Code-Review-1

(4 comments)

File TODO-RELEASE:

https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/eaee12b9_c649f521 PS2, Line 10: libosmo-abis API change New function ipa_client_conn_open2 better s/API change/new API/g, it helps me quickly understanding how to bump the libversion stuff.

File include/osmocom/abis/ipa.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/0fa3006e_ed0ccbbd PS2, Line 108: int ipa_client_conn_open2(struct ipa_client_conn *link, int timeout); connect_timeout?

File src/input/ipa.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/f177ff73_dd4c9cc1 PS2, Line 136: osmo_timer_del(&link->timer); you should delete the timer before returning above, otherwise you leave it set if the socket returned an error before timeout.

https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/9207107e_524632ea PS2, Line 246: int ipa_client_conn_open2(struct ipa_client_conn *link, int timeout) connect_tmeout