Attention is currently required from: fixeria, daniel.

Patch set 2:Code-Review -1

View Change

4 comments:

• File TODO-RELEASE:

  • Patch Set #2, Line 10: libosmo-abis API change New function ipa_client_conn_open2

    better s/API change/new API/g, it helps me quickly understanding how to bump the libversion stuff.

• File include/osmocom/abis/ipa.h:

  • Patch Set #2, Line 108: int ipa_client_conn_open2(struct ipa_client_conn *link, int timeout);

    connect_timeout?

• File src/input/ipa.c:

  • Patch Set #2, Line 136: osmo_timer_del(&link->timer);

    you should delete the timer before returning above, otherwise you leave it set if the socket returned an error before timeout.

  • Patch Set #2, Line 246: int ipa_client_conn_open2(struct ipa_client_conn *link, int timeout)

    connect_tmeout

To view, visit change 30616. To unsubscribe, or for help writing mail filters, visit settings.