Attention is currently required from: fixeria, laforge.

osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335?usp=email )

Change subject: Revert "clang-format: set ColumnLimit: 0" ......................................................................

Patch Set 1: Code-Review-1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335/comment/0cfff249_919... : PS1, Line 11: Reason for revert: we don't want clang-format to actively generate arbitrarily long line lengths. According to https://clang.llvm.org/docs/ClangFormatStyleOptions.html#columnlimit, this is not how it works:

A column limit of 0 means that there is no column limit. In this case, clang-format will respect the input’s line breaking decisions within statements unless they contradict other rules.

"respect the input's line breaking decisions" sounds like what we would like to have from code review I've seen, if we set any line length then it will generate lines with the given length.