Attention is currently required from: fixeria, laforge.

Patch set 1:Code-Review -1

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 11: Reason for revert: we don't want clang-format to actively generate arbitrarily long line lengths.

    According to https://clang.llvm.org/docs/ClangFormatStyleOptions.html#columnlimit, this is not how it works:

    A column limit of 0 means that there is no column limit. In this case,
    clang-format will respect the input’s line breaking decisions within
    statements unless they contradict other rules.

    "respect the input's line breaking decisions" sounds like what we would like to have from code review I've seen, if we set any line length then it will generate lines with the given length.

To view, visit change 42335. To unsubscribe, or for help writing mail filters, visit settings.