Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/osmo-mgw/+/39730?usp=email )
Change subject: MGCP extension: add parameters for TW-TS-001 & TW-TS-002
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
this should be documented in
doc/manuals/chapters/mgcp_extensions.adoc.
That chapter begins with this sentence:
"The following non-standard extensions are understood by OsmoMGW."
Thus it feels wrong to me to use this chapter, or rather the OsmoMGW manual in general, as
a place to document a protocol extension that exists between OsmoBSC and tw-e1abis-mgw -
but is not currently implemented in OsmoMGW.
I see two possible solutions:
1) Document the newly created extension somewhere else, somewhere other than OsmoMGW
manual;
2) Extend my code patch to add support for the new extension not only to
libosmo-mgcp-client, but also to OsmoMGW-E1, so that OsmoMGW manual will *become* a
sensible place to document it.
I am going to look into the feasibility of option 2.
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/39730/comment/49201b15_b25be00b?usp… :
PS1, Line 1436: pt, (int) mgcp_msg->param.amr_octet_aligned);
remove spacing between type cast and variable, here
and below.
Acknowledged
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/39730?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I0d58e6d84418f50670c8ab7cf8490af3bc2f5c26
Gerrit-Change-Number: 39730
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Mar 2025 17:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>