Attention is currently required from: pespin.

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    this should be documented in doc/manuals/chapters/mgcp_extensions.adoc.

    That chapter begins with this sentence:

    "The following non-standard extensions are understood by OsmoMGW."

    Thus it feels wrong to me to use this chapter, or rather the OsmoMGW manual in general, as a place to document a protocol extension that exists between OsmoBSC and tw-e1abis-mgw - but is not currently implemented in OsmoMGW.

    I see two possible solutions:

    1) Document the newly created extension somewhere else, somewhere other than OsmoMGW manual;

    2) Extend my code patch to add support for the new extension not only to libosmo-mgcp-client, but also to OsmoMGW-E1, so that OsmoMGW manual will *become* a sensible place to document it.

    I am going to look into the feasibility of option 2.

• File src/libosmo-mgcp-client/mgcp_client.c:

  • Patch Set #1, Line 1436: pt, (int) mgcp_msg->param.amr_octet_aligned);

    remove spacing between type cast and variable, here and below.

    Acknowledged

To view, visit change 39730. To unsubscribe, or for help writing mail filters, visit settings.