Attention is currently required from: daniel, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740?usp=email )
Change subject: gbproxy: Fix several tests on titan 11 ......................................................................
Patch Set 1:
(7 comments)
File gbproxy/GBProxy_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/0c35e867_6a52a... : PS1, Line 2722: [] pt.receive(BssgpStatusIndication:?) { repeat; } cosmetic: shift right
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/7864bff9_e46f0... : PS1, Line 2744: defaults It's only one now. Also, don't you still need to `deactivate()` it?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/cb8d86d4_6628e... : PS1, Line 2753: PESPIN debugging leftovers
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/4d541fa4_95355... : PS1, Line 2764: log2str I still find it so clumsy: why not just keeping the `setverdict(...)` as-is and simply adding `Misc_Helpers.f_shutdown(__BFILE__, __LINE__)` if you want to stop the testcase here? No! We want one overloaded statement doing everything in one go, requiring `log2str()`, and resulting in code moving further to the right side of the screen...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/9146ba64_9c3a5... : PS1, Line 2921: f_get_pcu_idx_ct BTW, you can use `__SCOPE__` to print an function/altstep name, i.e. `log(__SCOPE__, "(): ...)`.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/964f1c45_f2e6d... : PS1, Line 2954: defaults Likewise, don't you need to `deactivate()` it anymore?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41740/comment/5aa9f7b9_98eaf... : PS1, Line 2956: /* Activate one altsteps for all PCU NSE */ : var default d := activate(as_count_bvc0_block(g_roi)); : : f_sleep(3.0); : : d Does not look like we need to activate altsteps in background here?
```suggestion T.start(3.0); alt { [] as_count_bvc0_block(g_roi); /* repeats */ [] T.timeout { } } ```