Attention is currently required from: daniel, osmith, pespin.

View Change

7 comments:

• File gbproxy/GBProxy_Tests.ttcn:

  • Patch Set #1, Line 2722: [] pt.receive(BssgpStatusIndication:?) { repeat; }

    cosmetic: shift right

  • Patch Set #1, Line 2744: defaults

    It's only one now. Also, don't you still need to `deactivate()` it?

  • Patch Set #1, Line 2753: PESPIN

    debugging leftovers

  • Patch Set #1, Line 2764: log2str

    I still find it so clumsy: why not just keeping the `setverdict(...)` as-is and simply adding `Misc_Helpers.f_shutdown(__BFILE__, __LINE__)` if you want to stop the testcase here? No! We want one overloaded statement doing everything in one go, requiring `log2str()`, and resulting in code moving further to the right side of the screen...

  • Patch Set #1, Line 2921: f_get_pcu_idx_ct

    BTW, you can use `__SCOPE__` to print an function/altstep name, i.e. `log(__SCOPE__, "(): ...)`.

  • Patch Set #1, Line 2954: defaults

    Likewise, don't you need to `deactivate()` it anymore?

  • Patch Set #1, Line 2956:

    	/* Activate one altsteps for all PCU NSE */
    	var default d := activate(as_count_bvc0_block(g_roi));
    
    	f_sleep(3.0);
    
    	d
    

    Does not look like we need to activate altsteps in background here?

    ```suggestion
    	T.start(3.0);
    	alt {
    	[] as_count_bvc0_block(g_roi); /* repeats */
    	[] T.timeout { }
    	}
    ```

To view, visit change 41740. To unsubscribe, or for help writing mail filters, visit settings.