Attention is currently required from: Hoernchen.

osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email )

Change subject: fw source: force reformat once and for all ......................................................................

Patch Set 1: Code-Review-1

(5 comments)

Patchset:

PS1: went through the first files this patch touches and pointed out where the config would IMHO need to be adjusted to not do these kinds of reformattings

File ccid_common/ccid_device.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/71f02887_4c6... : PS1, Line 547: // break; not useful IMHO. this is also in other places in this patch.

File ccid_common/ccid_proto.h:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/c3dbb98b_cca... : PS1, Line 366: #define CCID_CMD_STATUS_TIME_EXT 0x80 here and in enum ccid_error_code below, it is more readable to keep the values directly below each other IMHO

File ccid_common/ccid_proto.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/237bb22e_2bf... : PS1, Line 70: { CCID_ERR_CMD_ABORTED, "CMD_ABORTED" },

for the record, I don't think this is an improvement in readability at all.

+1

File ccid_common/iso7816_3.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/0b5ba4a2_681... : PS1, Line 50: 0, doesn't seem useful to reformat it like this?