Attention is currently required from: Hoernchen.
Patch set 1:Code-Review -1
5 comments:
Patchset:
went through the first files this patch touches and pointed out where the config would IMHO need to be adjusted to not do these kinds of reformattings
File ccid_common/ccid_device.c:
Patch Set #1, Line 547: // break;
not useful IMHO. this is also in other places in this patch.
File ccid_common/ccid_proto.h:
Patch Set #1, Line 366: #define CCID_CMD_STATUS_TIME_EXT 0x80
here and in enum ccid_error_code below, it is more readable to keep the values directly below each other IMHO
File ccid_common/ccid_proto.c:
Patch Set #1, Line 70: { CCID_ERR_CMD_ABORTED, "CMD_ABORTED" },
for the record, I don't think this is an improvement in readability at all.
+1
File ccid_common/iso7816_3.c:
doesn't seem useful to reformat it like this?
To view, visit change 42330. To unsubscribe, or for help writing mail filters, visit settings.