Attention is currently required from: csaba.sipos, fixeria.

pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................

Patch Set 3:

(3 comments)

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/dd51bde8_496c588f?usp=... : PS3, Line 617: { 0x01, "BCF" }, /* Base Control Function */

I assume you would like to see something like in abis_om2000.c […]

I see it's done this way already in all value_string already existing in the file, so fine leaving it as is for now.

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/7af618c6_c188a88d?usp=... : PS3, Line 638: { 0x0, "Enabled" },

can we have defines or enum for all of these? […]

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/6786c31f_7a22cd21?usp=... : PS3, Line 1853: if (find_element

For BTS_ALARM the object id and object state and the object_id_and_state are all optional (but possi […]

IN any case, what's the point in doing "if (foobar());" ?

There's no point, simply do "foobar();" then...