Attention is currently required from: csaba.sipos, fixeria.

View Change

3 comments:

• File src/osmo-bsc/bts_nokia_site.c:

  • Patch Set #3, Line 617: { 0x01, "BCF" }, /* Base Control Function */

    I assume you would like to see something like in abis_om2000.c […]

    I see it's done this way already in all value_string already existing in the file, so fine leaving it as is for now.

  • Patch Set #3, Line 638: { 0x0, "Enabled" },

    can we have defines or enum for all of these? […]

    Done

  • Patch Set #3, Line 1853: if (find_element

    For BTS_ALARM the object id and object state and the object_id_and_state are all optional (but possi […]

    IN any case, what's the point in doing "if (foobar());" ?

    There's no point, simply do "foobar();" then...

To view, visit change 39416. To unsubscribe, or for help writing mail filters, visit settings.