Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30761 )

Change subject: isdndlc: Fix documentation ......................................................................

Patch Set 3:

(7 comments)

File src/core/isdnhdlc.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/152d7397_58920891 PS3, Line 100: excluding the CRC. please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/4b9d8d9c_696ad1b3 PS3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/16757f4d_9eb8ee83 PS3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. Avoid multiple line dereference - prefer 'CRC.returns'

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/21f8b94c_a50a2d78 PS3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/92556437_724d57d0 PS3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/511b8970_805be2dd PS3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. Avoid multiple line dereference - prefer 'OSMO_HDLC_FRAMING_ERROR.If'

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/ef148630_f1600a16 PS3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)