Attention is currently required from: laforge.

View Change

7 comments:

• File src/core/isdnhdlc.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859):

    Patch Set #3, Line 100: excluding the CRC.

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859):

    Patch Set #3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR.

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859):

    Patch Set #3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR.

    Avoid multiple line dereference - prefer 'CRC.returns'

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859):

    Patch Set #3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR.

    need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859):

    Patch Set #3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR.

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859):

    Patch Set #3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR.

    Avoid multiple line dereference - prefer 'OSMO_HDLC_FRAMING_ERROR.If'

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859):

    Patch Set #3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR.

    need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)

To view, visit change 30761. To unsubscribe, or for help writing mail filters, visit settings.