Attention is currently required from: laforge, tempest, tnt, ttsou.

fixeria has posted comments on this change by tempest. ( https://gerrit.osmocom.org/c/osmo-trx/+/41231?usp=email )

Change subject: trx: Fix tx/rx-sps 4 for USRP1 devices ......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1:

should I fix it as the linter is suggesting? The multi-line function call format it's complaining ab […]

You're changing the existing code, which is not properly formatted in the first place. So I believe we can bypass the linter here. I can do that when the commit message is fixed.

Commit Message:

https://gerrit.osmocom.org/c/osmo-trx/+/41231/comment/a4df052b_0edaea13?usp=... : PS1, Line 9: The existing code sets the pingOffset variable to -7231(269 - 7500) with tx-sps = 4. The (apparent) correct value for pingOffset for tx/rx-sps 4 is 272. Please adjust the commit message formatting to avoid very long lines: wrap it to about 72 characters or so.