Attention is currently required from: laforge, tempest, tnt, ttsou.

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    should I fix it as the linter is suggesting? The multi-line function call format it's complaining ab […]

    You're changing the existing code, which is not properly formatted in the first place.
    So I believe we can bypass the linter here. I can do that when the commit message is fixed.

• Commit Message:

  • Patch Set #1, Line 9: The existing code sets the pingOffset variable to -7231(269 - 7500) with tx-sps = 4. The (apparent) correct value for pingOffset for tx/rx-sps 4 is 272.

    Please adjust the commit message formatting to avoid very long lines: wrap it to about 72 characters or so.

To view, visit change 41231. To unsubscribe, or for help writing mail filters, visit settings.