Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email )
Change subject: per-HNB GTP-U traffic counters via nft ......................................................................
Patch Set 13:
(3 comments)
Patchset:
PS6:
With thew new comments you added it's "good enough" because one can clearly see which thread execute […]
thanks for accepting this ... bikeshed =)
File src/osmo-hnbgw/nft_kpi.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/76de991e_32a66002 PS9, Line 994: nft_kpi_get_counters_schedule();
As mentioned, I'm just asking to account for the elapsed time between triggers by writing a few more […]
Done
File src/osmo-hnbgw/nft_kpi.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/038fd872_44854a27 PS12, Line 694: unsigned long period_us = osmo_tdef_get(hnbgw_T_defs, -34, OSMO_TDEF_US, 1000000);
yes, this is simple, usual in code, so I'm not asking something out of this world I think. […]
follow-up. we need to not delay this any further.
For the current customer, whether the timer fires exactly 60 or maybe just 59 times per minute is irrelevant.
-
neels