Attention is currently required from: laforge, pespin.

View Change

3 comments:

• Patchset:

  • Patch Set #6:

    With thew new comments you added it's "good enough" because one can clearly see which thread execute […]

    thanks for accepting this ... bikeshed =)

• File src/osmo-hnbgw/nft_kpi.c:

  • Patch Set #9, Line 994: nft_kpi_get_counters_schedule();

    As mentioned, I'm just asking to account for the elapsed time between triggers by writing a few more […]

    Done

• File src/osmo-hnbgw/nft_kpi.c:

  • Patch Set #12, Line 694: unsigned long period_us = osmo_tdef_get(hnbgw_T_defs, -34, OSMO_TDEF_US, 1000000);

    yes, this is simple, usual in code, so I'm not asking something out of this world I think. […]

    follow-up. we need to not delay this any further.

    For the current customer, whether the timer fires exactly 60 or maybe just 59 times per minute is irrelevant.

To view, visit change 36539. To unsubscribe, or for help writing mail filters, visit settings.