Attention is currently required from: Hoernchen, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30612 )

Change subject: trxcon: allow extending FBSB timeout (quirks for slow PHYs) ......................................................................

Patch Set 3:

(2 comments)

File src/host/trxcon/src/trxcon_main.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/30612/comment/bb212623_e46bd075 PS2, Line 71: int phyq_fbsb_extend_fns;

unsigned? this cannot be negative right?

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/30612/comment/b6b5c3e5_25a5cc01 PS2, Line 243: app_data.phyq_fbsb_extend_fns = atoi(optarg);

ah so you are declaring it as an int just in order to be able to use atoi. […]

Ok, I spent additional time switching from atoi() to strtoul():

https://gerrit.osmocom.org/c/osmocom-bb/+/30729

But now I don't see how can I detect negative values and print an error. The strtoul() would simply return a huge value and indicate no errors. In any case, this is already taking more time than implementing the FBSB timeout extension feature itself, so I am giving up. Not critical.