Attention is currently required from: Hoernchen, laforge, pespin.

View Change

2 comments:

• File src/host/trxcon/src/trxcon_main.c:

  • Patch Set #2, Line 71: int phyq_fbsb_extend_fns;

    unsigned? this cannot be negative right?

    Done

  • Patch Set #2, Line 243: app_data.phyq_fbsb_extend_fns = atoi(optarg);

    ah so you are declaring it as an int just in order to be able to use atoi. […]

    Ok, I spent additional time switching from atoi() to strtoul():

    https://gerrit.osmocom.org/c/osmocom-bb/+/30729

    But now I don't see how can I detect negative values and print an error. The strtoul() would simply return a huge value and indicate no errors. In any case, this is already taking more time than implementing the FBSB timeout extension feature itself, so I am giving up. Not critical.

To view, visit change 30612. To unsubscribe, or for help writing mail filters, visit settings.