pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27346 )
Change subject: vty: Fix cmd 'no echo-interval' doing nothing ......................................................................
vty: Fix cmd 'no echo-interval' doing nothing
It was incorrectly implemented and in practice was a NOOP.
Change-Id: I5e03c4965d05871d3f2e56675da6e75af0ec18c2 --- M ggsn/ggsn_vty.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved
diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c index 1738e70..9591bf7 100644 --- a/ggsn/ggsn_vty.c +++ b/ggsn/ggsn_vty.c @@ -389,10 +389,9 @@ NO_STR "Send an echo request to this static GGSN every interval.\n") { struct ggsn_ctx *ggsn = (struct ggsn_ctx *) vty->index; - int prev_interval = ggsn->cfg.echo_interval; struct sgsn_peer *sgsn;
- if (prev_interval == ggsn->cfg.echo_interval) + if (ggsn->cfg.echo_interval == 0) return CMD_SUCCESS;
ggsn->cfg.echo_interval = 0;
-
pespin