pespin submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved
vty: Fix cmd 'no echo-interval' doing nothing

It was incorrectly implemented and in practice was a NOOP.

Change-Id: I5e03c4965d05871d3f2e56675da6e75af0ec18c2
---
M ggsn/ggsn_vty.c
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c
index 1738e70..9591bf7 100644
--- a/ggsn/ggsn_vty.c
+++ b/ggsn/ggsn_vty.c
@@ -389,10 +389,9 @@
NO_STR "Send an echo request to this static GGSN every interval.\n")
{
struct ggsn_ctx *ggsn = (struct ggsn_ctx *) vty->index;
- int prev_interval = ggsn->cfg.echo_interval;
struct sgsn_peer *sgsn;

- if (prev_interval == ggsn->cfg.echo_interval)
+ if (ggsn->cfg.echo_interval == 0)
return CMD_SUCCESS;

ggsn->cfg.echo_interval = 0;

To view, visit change 27346. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I5e03c4965d05871d3f2e56675da6e75af0ec18c2
Gerrit-Change-Number: 27346
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: keith <keith@rhizomatica.org>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged