Attention is currently required from: manawyrm, roox, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27841 )
Change subject: e1oip: Add rate_ctr for IP->E1 RIFO overflows ......................................................................
Patch Set 6:
(1 comment)
File src/octoi/e1oip.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/27841/comment/3edb64d7_d984298f PS2, Line 255: rc = frame_rifo_in(&iline->e1t.rifo, frame_buf, fn32+i);
Yeah, I think it's too much of a misnomer because in the stat in case of a desync we'll end up with […]
we already have "pkts_out_of_win" for outside the fn16 window at the packet receive time, so my out_of_win suggestion is a bad idea. I don't really like any of the choices particularly well :/ Two counters sounds like the best approach. The overhead is minimal I guess.
-
laforge