Attention is currently required from: manawyrm, roox, tnt.
View Change
1 comment:
File src/octoi/e1oip.c:
Patch Set #2, Line 255: rc = frame_rifo_in(&iline->e1t.rifo, frame_buf, fn32+i);
Yeah, I think it's too much of a misnomer because in the stat in case of a desync we'll end up with […]
we already have "pkts_out_of_win" for outside the fn16 window at the packet receive time, so my out_of_win suggestion is a bad idea. I don't really like any of the choices particularly well :/ Two counters sounds like the best approach. The overhead is minimal I guess.
To view, visit change 27841. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ie0e8bb2f5d2ae4256952f6bf69e514d5c2627a76
Gerrit-Change-Number: 27841
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: manawyrm <osmocom.account@tbspace.de>
Gerrit-Reviewer: roox <mardnh@gmx.de>
Gerrit-Reviewer: tnt <tnt@246tNt.com>
Gerrit-Attention: manawyrm <osmocom.account@tbspace.de>
Gerrit-Attention: roox <mardnh@gmx.de>
Gerrit-Attention: tnt <tnt@246tNt.com>
Gerrit-Comment-Date: Wed, 20 Apr 2022 17:57:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: tnt <tnt@246tNt.com>
Gerrit-MessageType: comment