Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918 ) Change subject: import latest e1-tracer host software ...................................................................... Patch Set 2: (51 comments) File software/e1-tracer/crc4itu.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/daa377cb_4047… PS2, Line 18: * The crc4itu_init() function returns the inital \c crc value and must be called 'inital' may be misspelled - perhaps 'initial'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/398ef445_b494… PS2, Line 65: typedef uint_fast8_t crc_t; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/07c4220b_1435… PS2, Line 75: return 0x0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/f1ecdc82_71a7… PS2, Line 98: return crc; please, no spaces at the start of a line File software/e1-tracer/crc4itu.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/d5cce08e_c2d4… PS2, Line 26: 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/cdc17eab_478c… PS2, Line 27: 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/c1cab83f_2e1f… PS2, Line 28: 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/12e8294f_faac… PS2, Line 29: 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/1dd200e3_3d3e… PS2, Line 30: 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/e0fd9a52_d2e8… PS2, Line 31: 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/27a072f3_6041… PS2, Line 32: 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04, 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/5f56ea96_fbd8… PS2, Line 33: 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/b22ee3fb_2ef9… PS2, Line 34: 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/fdf71f35_6c34… PS2, Line 35: 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/270a71ee_8cfb… PS2, Line 36: 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/3d953c67_12db… PS2, Line 37: 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/7fa94014_da3e… PS2, Line 38: 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/45ffd902_62d6… PS2, Line 39: 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/dc0353cf_8fc1… PS2, Line 40: 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/ffaa5b0a_35af… PS2, Line 41: 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04 please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/98c5b8d7_6c56… PS2, Line 47: const unsigned char *d = (const unsigned char *)data; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/6259b4a2_f023… PS2, Line 48: unsigned int tbl_idx; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/4f753585_c4a0… PS2, Line 50: while (data_len--) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/cbcf93b0_3d1c… PS2, Line 51: tbl_idx = (crc << 4) ^ *d; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/64564a0c_9ab8… PS2, Line 51: tbl_idx = (crc << 4) ^ *d; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/d3bc14da_cc16… PS2, Line 52: crc = crc_table[tbl_idx] & 0xf; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/53b7e38c_4645… PS2, Line 52: crc = crc_table[tbl_idx] & 0xf; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/323b1f03_e3b3… PS2, Line 53: d++; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/08f1ecd5_7190… PS2, Line 53: d++; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/f392879b_7554… PS2, Line 54: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/26c7535a_e9f4… PS2, Line 55: return crc & 0xf; please, no spaces at the start of a line File software/e1-tracer/dump.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/2415ae3f_522d… PS2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/3b11581c_ecba… PS2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File software/e1-tracer/hdlc-decode-pipe.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/642763b0_2ef4… PS2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/8af61bbf_1147… PS2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File software/e1-tracer/idt82v2081.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/8a11e675_c7ed… PS2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/e8185bed_4ca7… PS2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File software/e1-tracer/idt82v2081_regs.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/02f943ed_ca39… PS2, Line 37: #define IDT_GCF_T1E1_E1 (0 << 2) please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/ea829004_d1f0… PS2, Line 38: #define IDT_GCF_T1E1_T1 (1 << 2) please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/2d638c56_af3c… PS2, Line 39: #define IDT_GCF_T1E1_MASK (1 << 2) please, no space before tabs File software/e1-tracer/idt82v2081_usb.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/cd5727dc_e8bc… PS2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/dc53bb79_1773… PS2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File software/e1-tracer/main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/ddce8ec0_3c28… PS2, Line 18: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/aac7f872_c666… PS2, Line 19: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File software/e1-tracer/osmo_e1f.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/afc01f6d_51c0… PS2, Line 22: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/e97e54cc_077c… PS2, Line 23: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File software/e1-tracer/osmo_e1f.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/c3e8231e_7ce4… PS2, Line 20: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/808f3fcf_e133… PS2, Line 21: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/a4749033_2591… PS2, Line 205: } else { else is not generally useful after a break or return File software/e1-tracer/replay.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/4d9fd898_3a16… PS2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/d469d3d5_fe65… PS2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I9319c1eb8f822830307c1a181d357c58ce43efba Gerrit-Change-Number: 29918 Gerrit-PatchSet: 2 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Comment-Date: Sun, 30 Oct 2022 21:37:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment