Attention is currently required from: laforge.
51 comments:
File software/e1-tracer/crc4itu.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 18: * The crc4itu_init() function returns the inital \c crc value and must be called
'inital' may be misspelled - perhaps 'initial'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 65: typedef uint_fast8_t crc_t;
do not add new typedefs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 75: return 0x0;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 98: return crc;
please, no spaces at the start of a line
File software/e1-tracer/crc4itu.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 26: 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 27: 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 28: 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 29: 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 30: 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 31: 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 32: 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04, 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 33: 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 34: 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 35: 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 36: 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 37: 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 38: 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 39: 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 40: 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 41: 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 47: const unsigned char *d = (const unsigned char *)data;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 48: unsigned int tbl_idx;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 50: while (data_len--) {
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 51: tbl_idx = (crc << 4) ^ *d;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 51: tbl_idx = (crc << 4) ^ *d;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 52: crc = crc_table[tbl_idx] & 0xf;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 52: crc = crc_table[tbl_idx] & 0xf;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 55: return crc & 0xf;
please, no spaces at the start of a line
File software/e1-tracer/dump.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc.,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
File software/e1-tracer/hdlc-decode-pipe.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc.,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
File software/e1-tracer/idt82v2081.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc.,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
File software/e1-tracer/idt82v2081_regs.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 37: #define IDT_GCF_T1E1_E1 (0 << 2)
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 38: #define IDT_GCF_T1E1_T1 (1 << 2)
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 39: #define IDT_GCF_T1E1_MASK (1 << 2)
please, no space before tabs
File software/e1-tracer/idt82v2081_usb.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc.,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
File software/e1-tracer/main.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 18: * with this program; if not, write to the Free Software Foundation, Inc.,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 19: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
File software/e1-tracer/osmo_e1f.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 22: * with this program; if not, write to the Free Software Foundation, Inc.,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 23: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
File software/e1-tracer/osmo_e1f.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 20: * with this program; if not, write to the Free Software Foundation, Inc.,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 21: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 205: } else {
else is not generally useful after a break or return
File software/e1-tracer/replay.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 17: * with this program; if not, write to the Free Software Foundation, Inc.,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-571):
Patch Set #2, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
To view, visit change 29918. To unsubscribe, or for help writing mail filters, visit settings.