Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31049 )

Change subject: llc: Initial support for GRR-UNITDATA.ind/req ......................................................................

Patch Set 2:

(2 comments)

File src/llc/llc.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/16c76e3d_28ac1a10 PS2, Line 315: gprs_llc_prim_alloc_grr_unitdata_req(lle->llme->tlli, NULL, 4096 - sizeof(llc_prim))

Shorter and still readable I'd say: […]

I still prefer the way I added it, it allows for much easier extension of code later if we need to do more stuff based on the condition (like filling specific primitive fields).

https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/46d274bb_be3ea0f0 PS2, Line 758: llc_prim_tx->ll.unitdata_ind.apply_gea = !drop_cipherable; /* TODO: is this correct? */

Can you tell me how we handle TODOs/FIXMEs in our codebase/when we upload them into our codebase? I' […]

In this specific case, I'm merely moving this code, so I'm basically touching nothing here.

In general, we add TODO/FIXME comments for missing features, or stuff which needs a second careful look with probable work related. In this case, libosmo-gprs is still in intensive initial development so I'm pushing stuff which may still lack some features or some code may be flaky. Those will be fixed in the near future.