Attention is currently required from: arehbein.

View Change

2 comments:

• File src/llc/llc.c:

  • Patch Set #2, Line 315: gprs_llc_prim_alloc_grr_unitdata_req(lle->llme->tlli, NULL, 4096 - sizeof(llc_prim))

    Shorter and still readable I'd say: […]

    I still prefer the way I added it, it allows for much easier extension of code later if we need to do more stuff based on the condition (like filling specific primitive fields).

  • Patch Set #2, Line 758: llc_prim_tx->ll.unitdata_ind.apply_gea = !drop_cipherable; /* TODO: is this correct? */

    Can you tell me how we handle TODOs/FIXMEs in our codebase/when we upload them into our codebase? I' […]

    In this specific case, I'm merely moving this code, so I'm basically touching nothing here.

    In general, we add TODO/FIXME comments for missing features, or stuff which needs a second careful look with probable work related.
    In this case, libosmo-gprs is still in intensive initial development so I'm pushing stuff which may still lack some features or some code may be flaky.
    Those will be fixed in the near future.

To view, visit change 31049. To unsubscribe, or for help writing mail filters, visit settings.