Attention is currently required from: arehbein, laforge, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34338?usp=email )
Change subject: stream_srv: Fix connection error handling ......................................................................
Patch Set 2:
(2 comments)
File src/stream_srv.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/4a9040f5_53ab2d3e PS1, Line 493: if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) {
for a srv it is probably unlikely or unusable. […]
Yeah, most likely. @arehbein@sysmocom.de just found out that osmo_io also doesn't like its read/write callbacks being NULL (in https://gerrit.osmocom.org/c/osmo-bsc/+/34526).
I guess it should be changed there.
File src/stream_srv.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/83103342_2d295e53 PS2, Line 492: } else {
did you think about simply doing early return here instead?
Done
-
daniel