Attention is currently required from: arehbein, laforge, pespin.

View Change

2 comments:

• File src/stream_srv.c:

  • Patch Set #1, Line 493: if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) {

    for a srv it is probably unlikely or unusable. […]

    Yeah, most likely. @arehbein@sysmocom.de just found out that osmo_io also doesn't like its read/write callbacks being NULL (in https://gerrit.osmocom.org/c/osmo-bsc/+/34526).

    I guess it should be changed there.

• File src/stream_srv.c:

  • Patch Set #2, Line 492: } else {

    did you think about simply doing early return here instead?

    Done

To view, visit change 34338. To unsubscribe, or for help writing mail filters, visit settings.