Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29512 )

Change subject: osmux: Proper encoding of osmux frames when when AMR FT changes ......................................................................

Patch Set 1: Code-Review+2

(2 comments)

File src/osmux.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/8a360230_5d7dc04c PS1, Line 470: !state.rtph

Why are you changing this? I guess because below in your code you're doing !foo. […]

I just really rewrote the whole code several times before finding the best way, so it ended up this way.

https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/e3863d66_a8d8bdc1 PS1, Line 535: struct amr_hdr *amrh

const?

I'll do a full pass of constifying everything possible in a follow up patch, I bet several things can be marked as const.